Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the demo compile with NDK #487

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make the demo compile with NDK #487

wants to merge 1 commit into from

Conversation

floppyhammer
Copy link
Contributor

Solving #472. Upgrade usvg to 0.20.0, which removes harfbuzz_rs dependency.

@floppyhammer
Copy link
Contributor Author

The demo shows some artifacts on Android, which doesn't occur in the last release. I'll open another PR to handle that.

@kognise kognise mentioned this pull request Feb 6, 2022
Open
@jdm
Copy link
Member

jdm commented Mar 27, 2022

@bors-servo r+
Thanks!

@bors-servo
Copy link
Contributor

📌 Commit 9c1f48a has been approved by jdm

bors-servo added a commit that referenced this pull request Mar 28, 2022
@bors-servo
Auto merge of #487 - floppyhammer:fix_android_demo, r=jdm
db0dfee 
Make the demo compile with NDK

Solving #472. Upgrade `usvg` to `0.20.0`, which removes `harfbuzz_rs` dependency.
@bors-servo
Copy link
Contributor

⌛ Testing commit 9c1f48a with merge db0dfee...

@bors-servo
Copy link
Contributor

💔 Test failed - checks-github

@jdm
Copy link
Member

jdm commented Mar 28, 2022 

error[E0599]: no function or associated item named `from_file` found for struct `Tree` in the current scope
  --> utils/svg-to-skia/src/main.rs:16:22
   |
16 |     let tree = Tree::from_file(&input_path, &Options::default()).unwrap();
   |                      ^^^^^^^^^ function or associated item not found in `Tree`

@floppyhammer
Copy link
Contributor Author

@jdm Should probably merge #493 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@floppyhammer @jdm @bors-servo